Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

add comment about misuse of enum set function.

Browse Source
This commit is contained in:
Campbell Barton
2012-10-20 14:16:56 +00:00
parent add48983ca
commit 18fa7589ef
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/makesrna/intern/rna_wm.c
View File

@@ -635,12 +635,19 @@ static void rna_wmKeyMapItem_keymodifier_set(PointerRNA *ptr, int value)
{ {
wmKeyMapItem *kmi = ptr->data; wmKeyMapItem *kmi = ptr->data;
if (value == ESCKEY); /* XXX, this should really be managed in an _itemf function,
else if (value >= AKEY) * giving a list of valid enums, then silently changing them when they are set is not
* a good precedent, don't do this unless you have a good reason! */
if (value == ESCKEY) {
/* pass */
}
else if (value >= AKEY) {
kmi->keymodifier = value; kmi->keymodifier = value;
else }
else {
kmi->keymodifier = 0; kmi->keymodifier = 0;
} }
}
static EnumPropertyItem *rna_KeyMapItem_type_itemf(bContext *UNUSED(C), PointerRNA *ptr, PropertyRNA *UNUSED(prop), static EnumPropertyItem *rna_KeyMapItem_type_itemf(bContext *UNUSED(C), PointerRNA *ptr, PropertyRNA *UNUSED(prop),