Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

code cleanup: dont set the namespace in STR_String.h - 'using namespace std', since this is included in many places.

Browse Source
This commit is contained in:
Campbell Barton
2012-02-23 02:36:30 +00:00
parent c8b53d2aaf
commit 190f5d1787
8 changed files with 23 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
intern/string/STR_String.h
View File

@@ -51,8 +51,6 @@
#include <cstring>
#include <cstdlib>
using namespace std;
#ifdef WITH_CXX_GUARDEDALLOC
#include "MEM_guardedalloc.h"
#endif
@@ -95,8 +93,10 @@ public:
inline void Clear() { Len = pData[0] = 0; }
inline const STR_String & Reverse()
{
for (int i1=0, i2=Len-1; i1<i2; i1++, i2--)
swap(pData[i1], pData[i2]); return *this;
for (int i1 = 0, i2 = Len - 1; i1 < i2; i1++, i2--) {
std::swap(pData[i1], pData[i2]);
}
return *this;
}
// Properties
@@ -133,7 +133,7 @@ public:
int FindOneOf(const char *set, int pos = 0) const;
int RFindOneOf(const char *set, int pos = 0) const;
vector<STR_String> Explode(char c) const;
std::vector<STR_String> Explode(char c) const;
// Formatting
STR_String& Upper();

16
intern/string/intern/STR_String.cpp
View File

@@ -699,23 +699,19 @@ rcSTR_String STR_String::Concat(const char *data, int len)
}
vector<STR_String> STR_String::Explode(char c) const
std::vector<STR_String> STR_String::Explode(char c) const
{
STR_String lcv = *this;
vector<STR_String> uc;
STR_String lcv = *this;
std::vector<STR_String> uc;
while (lcv.Length())
{
int pos = lcv.Find(c);
if (pos < 0)
{
if (pos < 0) {
uc.push_back(lcv);
lcv.Clear();
} else
{
}
else {
uc.push_back(lcv.Left(pos));
lcv = lcv.Mid(pos+1);
}