bmesh speedup: skip free-realloc while running CustomData_bmesh_merge() when nothing is changed (happens quite often that there is nothing to do).

This commit is contained in:
Campbell Barton
2013-05-09 10:41:05 +00:00
parent efcfe88adc
commit 1e784c54cd
2 changed files with 30 additions and 5 deletions

View File

@@ -115,13 +115,13 @@ void CustomData_update_typemap(struct CustomData *data);
/* same as the above, except that this will preserve existing layers, and only /* same as the above, except that this will preserve existing layers, and only
* add the layers that were not there yet */ * add the layers that were not there yet */
void CustomData_merge(const struct CustomData *source, struct CustomData *dest, bool CustomData_merge(const struct CustomData *source, struct CustomData *dest,
CustomDataMask mask, int alloctype, int totelem); CustomDataMask mask, int alloctype, int totelem);
/* bmesh version of CustomData_merge; merges the layouts of source and dest, /* bmesh version of CustomData_merge; merges the layouts of source and dest,
* then goes through the mesh and makes sure all the customdata blocks are * then goes through the mesh and makes sure all the customdata blocks are
* consistent with the new layout.*/ * consistent with the new layout.*/
void CustomData_bmesh_merge(struct CustomData *source, struct CustomData *dest, bool CustomData_bmesh_merge(struct CustomData *source, struct CustomData *dest,
CustomDataMask mask, int alloctype, struct BMesh *bm, const char htype); CustomDataMask mask, int alloctype, struct BMesh *bm, const char htype);
/** NULL's all members and resets the typemap. */ /** NULL's all members and resets the typemap. */
@@ -167,6 +167,7 @@ bool CustomData_has_layer(const struct CustomData *data, int type);
/* returns the number of layers with this type */ /* returns the number of layers with this type */
int CustomData_number_of_layers(const struct CustomData *data, int type); int CustomData_number_of_layers(const struct CustomData *data, int type);
int CustomData_number_of_layers_typemask(const struct CustomData *data, CustomDataMask mask);
/* duplicate data of a layer with flag NOFREE, and remove that flag. /* duplicate data of a layer with flag NOFREE, and remove that flag.
* returns the layer data */ * returns the layer data */

View File

@@ -1257,13 +1257,14 @@ static int customdata_typemap_is_valid(const CustomData *data)
} }
#endif #endif
void CustomData_merge(const struct CustomData *source, struct CustomData *dest, bool CustomData_merge(const struct CustomData *source, struct CustomData *dest,
CustomDataMask mask, int alloctype, int totelem) CustomDataMask mask, int alloctype, int totelem)
{ {
/*const LayerTypeInfo *typeInfo;*/ /*const LayerTypeInfo *typeInfo;*/
CustomDataLayer *layer, *newlayer; CustomDataLayer *layer, *newlayer;
void *data; void *data;
int i, type, number = 0, lasttype = -1, lastactive = 0, lastrender = 0, lastclone = 0, lastmask = 0, lastflag = 0; int i, type, number = 0, lasttype = -1, lastactive = 0, lastrender = 0, lastclone = 0, lastmask = 0, lastflag = 0;
bool change = false;
for (i = 0; i < source->totlayer; ++i) { for (i = 0; i < source->totlayer; ++i) {
layer = &source->layers[i]; layer = &source->layers[i];
@@ -1313,10 +1314,12 @@ void CustomData_merge(const struct CustomData *source, struct CustomData *dest,
newlayer->active_clone = lastclone; newlayer->active_clone = lastclone;
newlayer->active_mask = lastmask; newlayer->active_mask = lastmask;
newlayer->flag |= lastflag & (CD_FLAG_EXTERNAL | CD_FLAG_IN_MEMORY); newlayer->flag |= lastflag & (CD_FLAG_EXTERNAL | CD_FLAG_IN_MEMORY);
change = true;
} }
} }
CustomData_update_typemap(dest); CustomData_update_typemap(dest);
return change;
} }
void CustomData_copy(const struct CustomData *source, struct CustomData *dest, void CustomData_copy(const struct CustomData *source, struct CustomData *dest,
@@ -1779,6 +1782,17 @@ int CustomData_number_of_layers(const CustomData *data, int type)
return number; return number;
} }
int CustomData_number_of_layers_typemask(const CustomData *data, CustomDataMask mask)
{
int i, number = 0;
for (i = 0; i < data->totlayer; i++)
if (mask & CD_TYPE_AS_MASK(data->layers[i].type))
number++;
return number;
}
void *CustomData_duplicate_referenced_layer(struct CustomData *data, const int type, const int totelem) void *CustomData_duplicate_referenced_layer(struct CustomData *data, const int type, const int totelem)
{ {
CustomDataLayer *layer; CustomDataLayer *layer;
@@ -2324,7 +2338,7 @@ void CustomData_bmesh_init_pool(CustomData *data, int totelem, const char htype)
} }
} }
void CustomData_bmesh_merge(CustomData *source, CustomData *dest, bool CustomData_bmesh_merge(CustomData *source, CustomData *dest,
CustomDataMask mask, int alloctype, BMesh *bm, const char htype) CustomDataMask mask, int alloctype, BMesh *bm, const char htype)
{ {
BMHeader *h; BMHeader *h;
@@ -2334,6 +2348,10 @@ void CustomData_bmesh_merge(CustomData *source, CustomData *dest,
int iter_type; int iter_type;
int totelem; int totelem;
if (CustomData_number_of_layers_typemask(source, mask) == 0) {
return false;
}
/* copy old layer description so that old data can be copied into /* copy old layer description so that old data can be copied into
* the new allocation */ * the new allocation */
destold = *dest; destold = *dest;
@@ -2341,6 +2359,12 @@ void CustomData_bmesh_merge(CustomData *source, CustomData *dest,
destold.layers = MEM_dupallocN(destold.layers); destold.layers = MEM_dupallocN(destold.layers);
} }
if (CustomData_merge(source, dest, mask, alloctype, 0) == false) {
if (destold.layers)
MEM_freeN(destold.layers);
return false;
}
switch (htype) { switch (htype) {
case BM_VERT: case BM_VERT:
iter_type = BM_VERTS_OF_MESH; iter_type = BM_VERTS_OF_MESH;
@@ -2364,7 +2388,6 @@ void CustomData_bmesh_merge(CustomData *source, CustomData *dest,
totelem = bm->totvert; totelem = bm->totvert;
} }
CustomData_merge(source, dest, mask, alloctype, 0);
dest->pool = NULL; dest->pool = NULL;
CustomData_bmesh_init_pool(dest, totelem, htype); CustomData_bmesh_init_pool(dest, totelem, htype);
@@ -2395,6 +2418,7 @@ void CustomData_bmesh_merge(CustomData *source, CustomData *dest,
if (destold.pool) BLI_mempool_destroy(destold.pool); if (destold.pool) BLI_mempool_destroy(destold.pool);
if (destold.layers) MEM_freeN(destold.layers); if (destold.layers) MEM_freeN(destold.layers);
return true;
} }
void CustomData_bmesh_free_block(CustomData *data, void **block) void CustomData_bmesh_free_block(CustomData *data, void **block)