Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix (unreported) missing updates in scripts/docs after scene.update() removal.

Browse Source 
This should really have been done together with API changes, simple
usage of grep does the trick to catch most places needing updates.
This commit is contained in:
Bastien Montagne
2019-06-04 14:36:53 +02:00
parent 1d2e4c44bd
commit 33e8db94b1
25 changed files with 41 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/python/view_layer/test_background_set.py
View File

@@ -25,7 +25,7 @@ class UnitTesting(ViewLayerTesting):
bpy.context.window.scene = main_scene
# Update depsgraph.
main_scene.update()
bpy.context.view_layer.update()
# Safety check, there should be no objects in thew newly created scene.
self.assertEqual(0, len(bpy.context.depsgraph.objects))
@@ -35,7 +35,7 @@ class UnitTesting(ViewLayerTesting):
background_scene.objects[0].parent = background_scene.objects[1]
# Update depsgraph.
main_scene.update()
bpy.context.view_layer.update()
# Test if objects were properly added to depsgraph.
self.assertEqual(3, len(bpy.context.depsgraph.objects))
@@ -50,7 +50,7 @@ class UnitTesting(ViewLayerTesting):
main_scene.background_set = None
# Update depsgraph.
main_scene.update()
bpy.context.view_layer.update()
self.assertEqual(0, len(bpy.context.depsgraph.objects))

2
tests/python/view_layer/test_evaluation_selectability_a.py
View File

@@ -37,7 +37,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_kid = layer.collections.link(scene_collection_kid)
layer_collection_mom.enabled = False
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
cube.select_set(True)
self.assertTrue(cube.visible_get(), "Cube should be visible")

4
tests/python/view_layer/test_evaluation_selectability_b.py
View File

@@ -35,13 +35,13 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom = layer.collections.link(scene_collection_mom)
layer_collection_kid = layer.collections.link(scene_collection_kid)
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
cube.select_set(True)
layer_collection_mom.collections[layer_collection_kid.name].enabled = False
layer_collection_kid.enabled = False
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
self.assertFalse(cube.visible_get(), "Cube should be invisible")
self.assertFalse(cube.select_get(), "Cube should be unselected")

2
tests/python/view_layer/test_evaluation_selectability_c.py
View File

@@ -37,7 +37,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_kid = layer.collections.link(scene_collection_kid)
layer_collection_mom.enabled = True
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
cube.select_set(True)
self.assertTrue(cube.visible_get(), "Cube should be visible")

4
tests/python/view_layer/test_evaluation_selectability_d.py
View File

@@ -37,12 +37,12 @@ class UnitTesting(ViewLayerTesting):
layer_collection_kid = layer.collections.link(scene_collection_kid)
layer_collection_mom.enabled = True
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
cube.select_set(True)
layer_collection_mom.collections[layer_collection_kid.name].selectable = False
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Cube should be visible")
self.assertTrue(cube.select_get(), "Cube should be selected")

2
tests/python/view_layer/test_evaluation_selectability_e.py
View File

@@ -41,7 +41,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.collections[layer_collection_kid.name].selectable = False
layer_collection_kid.enabled = False
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Cube should be visible")
self.assertFalse(cube.select_get(), "Cube should be unselected")

4
tests/python/view_layer/test_evaluation_selectability_f.py
View File

@@ -23,14 +23,14 @@ class UnitTesting(ViewLayerTesting):
scene_collection = scene.master_collection.collections.new('collection')
layer_collection = view_layer.collections.link(scene_collection)
bpy.context.scene.update() # update depsgraph
view_layer.update() # update depsgraph
scene_collection.objects.link(cube)
self.assertTrue(layer_collection.enabled)
self.assertTrue(layer_collection.selectable)
bpy.context.scene.update() # update depsgraph
view_layer.update() # update depsgraph
cube.select_set(True)
self.assertTrue(cube.select_get())

2
tests/python/view_layer/test_evaluation_visibility_a.py
View File

@@ -40,7 +40,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.enabled = False
layer_collection_kid.enabled = True
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Object should be visible")

2
tests/python/view_layer/test_evaluation_visibility_b.py
View File

@@ -40,7 +40,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.collections[layer_collection_kid.name].enabled = False
layer_collection_kid.enabled = False
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertFalse(cube.visible_get(), "Object should be invisible")

2
tests/python/view_layer/test_evaluation_visibility_c.py
View File

@@ -40,7 +40,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.collections[layer_collection_kid.name].enabled = False
layer_collection_kid.enabled = True
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Object should be visible")

2
tests/python/view_layer/test_evaluation_visibility_d.py
View File

@@ -37,7 +37,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_kid = layer.collections.link(scene_collection_kid)
layer_collection_mom.enabled = True
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Object should be visible")

2
tests/python/view_layer/test_evaluation_visibility_e.py
View File

@@ -40,7 +40,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.enabled = True
layer_collection_kid.enabled = False
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Object should be visible")

2
tests/python/view_layer/test_evaluation_visibility_f.py
View File

@@ -41,7 +41,7 @@ class UnitTesting(ViewLayerTesting):
layer_collection_mom.collections[layer_collection_kid.name].enabled = False
layer_collection_kid.enabled = False
bpy.context.scene.update() # update depsgraph
layer.update() # update depsgraph
self.assertTrue(cube.visible_get(), "Object should be visible")

4
tests/python/view_layer/test_evaluation_visibility_j.py
View File

@@ -39,7 +39,7 @@ class UnitTesting(ViewLayerTesting):
self.assertTrue(layer_collection.enabled)
# Update depsgraph.
scene.update()
bpy.context.view_layer.update()
self.assertTrue(ob.visible_get())
@@ -47,7 +47,7 @@ class UnitTesting(ViewLayerTesting):
self.assertFalse(layer_collection.enabled)
# Update depsgraph.
scene.update()
bpy.context.view_layer.update()
self.assertFalse(ob.visible_get())

2
tests/python/view_layer/test_group_a.py
View File

@@ -34,7 +34,7 @@ class UnitTesting(ViewLayerTesting):
group = layer_collection.create_group()
# update depsgraph
scene.update()
bpy.context.view_layer.update()
# ############################################################

4
tests/python/view_layer/test_group_b.py
View File

@@ -41,13 +41,13 @@ class UnitTesting(ViewLayerTesting):
mom_layer_collection.selectable = True
# update depsgraph
scene.update()
bpy.context.view_layer.update()
# create group
group = grandma_layer_collection.create_group()
# update depsgraph
scene.update()
bpy.context.view_layer.update()
# compare
self.assertEqual(len(group.view_layer.collections), 1)

4
tests/python/view_layer/test_group_c.py
View File

@@ -38,13 +38,13 @@ class UnitTesting(ViewLayerTesting):
mom_layer_collection = grandma_layer_collection.collections[mom_scene_collection.name]
# update depsgraph
scene.update()
bpy.context.view_layer.update()
# create group
group = mom_layer_collection.create_group()
# update depsgraph
scene.update()
bpy.context.view_layer.update()
# ############################################################

6
tests/python/view_layer/test_group_e.py
View File

@@ -31,14 +31,14 @@ class UnitTesting(ViewLayerTesting):
scene.view_layers.remove(v)
# update depsgraph
scene.update()
view_layer.update()
# create group
group = bpy.data.groups.new("Switch")
group.objects.link(ob)
# update depsgraph
scene.update()
view_layer.update()
# instance the group
empty = bpy.data.objects.new("Empty", None)
@@ -57,7 +57,7 @@ class UnitTesting(ViewLayerTesting):
self.assertFalse(empty.select_get())
# update depsgraph
scene.update()
view_layer.update()
# delete the original object
bpy.ops.object.delete()

2
tests/python/view_layer/test_make_single_user.py
View File

@@ -39,7 +39,7 @@ class UnitTesting(ViewLayerTesting):
ob.select_set(True)
# update depsgraph
scene.update()
view_layer.update()
# test itself
bpy.ops.object.make_single_user(object=True)

2
tests/python/view_layer/test_scene_collection_delete.py
View File

@@ -37,7 +37,7 @@ class UnitTesting(ViewLayerTesting):
master_collection.collections.remove(collection_parent)
# Update depsgraph.
scene.update()
bpy.context.view_layer.update()
# ############################################################

3
tests/python/view_layer/test_scene_copy_f.py
View File

@@ -63,7 +63,8 @@ class UnitTesting(ViewLayerTesting):
self.assertNotEqual(scene, new_scene)
# update depsgrah
scene.update() # update depsgraph
for view_layer in scene.view_layers:
view_layer.update() # update depsgraph
# compare scenes
for h, layer in enumerate(scene.view_layers):

7
tests/python/view_layer/view_layer_common.py
View File

@@ -414,7 +414,7 @@ class ViewLayerTesting(unittest.TestCase):
bpy.data.objects.remove(ob, do_unlink=True)
elif del_mode == 'OPERATOR':
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
bpy.ops.object.select_all(action='DESELECT')
ob.select_set(True)
self.assertTrue(ob.select_get())
@@ -455,7 +455,7 @@ class ViewLayerTesting(unittest.TestCase):
scene_collection = scene.master_collection.collections.new("Collection")
layer.collections.link(scene_collection)
bpy.context.scene.update() # update depsgraph
bpy.context.view_layer.update() # update depsgraph
self.assertEqual(len(bpy.data.objects), 0)
@@ -728,7 +728,7 @@ class Clay:
self._object = bpy.data.objects.new('guinea pig', bpy.data.meshes.new('mesh'))
# update depsgraph
self._scene.update()
self._layer.update()
scene_collection_grandma = self._scene.master_collection.collections.new("Grandma")
scene_collection_mom = scene_collection_grandma.collections.new("Mom")
@@ -787,7 +787,6 @@ class Clay:
"""
ENGINE = 'BLENDER_CLAY'
self._scene.update() # update depsgraph
self._layer.update() # flush depsgraph evaluation
# change scene settings