Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix crash (segfault) in node editor.

Browse Source 
In some cases, we can have nodegroups without attached nodetree, this case is checked
in top `node_group_has_output()` entry point, but not in recursive `node_group_has_output_dfs()`.

Issue appeared after rB42824f4403db3a35, presumably because check on node flag itself
was skipping that case, which is no more possible when using ID tags.

Reported by sebastian_k over IRC, thanks.
This commit is contained in:
Bastien Montagne
2016-04-29 17:37:00 +02:00
parent 467e12514e
commit 57eb8539fc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/editors/space_node/node_relationships.c
View File

@@ -107,7 +107,7 @@ static bool node_group_has_output_dfs(bNode *node)
current_node = current_node->next) current_node = current_node->next)
{ {
if (current_node->type == NODE_GROUP) { if (current_node->type == NODE_GROUP) {
if (node_group_has_output_dfs(current_node)) { if (current_node->id && node_group_has_output_dfs(current_node)) {
return true; return true;
} }
} }