Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix 30562: bevel was infinite looping when adjacent faces had incompatible normals

Browse Source 
The fix is to check for cases where BME_Bevel_Dissolve_Disk was trying
to join faces with opposite normals and reverse one.  This isn't a great
fix, and the example blend has strange corners at the top after beveling,
but at least it stops the infinite loops.
This commit is contained in:
Howard Trickey
2012-03-17 15:47:48 +00:00
parent 7bc693d107
commit 8d3e79ddc9
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
source/blender/bmesh/tools/BME_bevel.c
View File

@@ -166,7 +166,18 @@ static int BME_Bevel_Dissolve_Disk(BMesh *bm, BMVert *v)
e = v->e; e = v->e;
l1 = e->l; l1 = e->l;
l2 = l1->radial_next; l2 = l1->radial_next;
bmesh_jfke(bm, l1->f, l2->f, e); if (l1->v == l2->v) {
/* faces have incompatible directions; need to reverse one */
if (!bmesh_loop_reverse(bm, l2->f)) {
BLI_assert(!"bevel dissolve disk cannot reverse loop");
return 0;
}
l2 = l1->radial_next;
}
if (!bmesh_jfke(bm, l1->f, l2->f, e)) {
BLI_assert(!"bevel dissolve disk cannot join faces");
return 0;
}
} }
e = v->e; e = v->e;
@@ -178,6 +189,14 @@ static int BME_Bevel_Dissolve_Disk(BMesh *bm, BMVert *v)
l1 = elast->l; l1 = elast->l;
l2 = l1->radial_next; l2 = l1->radial_next;
if (l1->v == l2->v) {
/* faces have incompatible directions */
if (!bmesh_loop_reverse(bm, l2->f)) {
BLI_assert(!"bevel dissolve disk cannot reverse loop");
return 0;
}
l2 = l1->radial_next;
}
bmesh_jfke(bm, l1->f, l2->f, elast); bmesh_jfke(bm, l1->f, l2->f, elast);
} }