From 952b728578bc0ecea22b3659067775102c0eea55 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Sun, 17 Oct 2010 08:04:28 +0000 Subject: [PATCH] Test stricter GCC compiler settings, these warnings will now give errors. - implicit function declaration. - no return type set for a function. - declaration after statement. This may be too strict but in general I prefer we don't allow commits with these warnings. Applies to cmake/gcc and scons/linux. --- CMakeLists.txt | 4 +--- build_files/scons/config/linux2-config.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 53ee69bd3e8..6ed3cd788b6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -920,10 +920,8 @@ INCLUDE_DIRECTORIES(${OPENGL_INCLUDE_DIR}) #----------------------------------------------------------------------------- # Extra compile flags - -# TODO: remove this and uncommend the global arg, but for now adding here keeps it managable IF(CMAKE_COMPILER_IS_GNUCC) - SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wunused-parameter") + SET(C_WARNINGS "${C_WARNINGS} -Wunused-parameter -Werror=declaration-after-statement -Werror=implicit-function-declaration -Werror=return-type") ENDIF(CMAKE_COMPILER_IS_GNUCC) SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${PLATFORM_CFLAGS} ${C_WARNINGS}") diff --git a/build_files/scons/config/linux2-config.py b/build_files/scons/config/linux2-config.py index f3e0085125a..fd42e61da0c 100644 --- a/build_files/scons/config/linux2-config.py +++ b/build_files/scons/config/linux2-config.py @@ -204,7 +204,7 @@ REL_CCFLAGS = ['-O2'] ##ARFLAGS = ruv ##ARFLAGSQUIET = ru ## -C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wunused-parameter'] +C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wunused-parameter', '-Werror=declaration-after-statement', '-Werror=implicit-function-declaration', '-Werror=return-type'] CC_WARN = ['-Wall'] CXX_WARN = ['-Wno-invalid-offsetof', '-Wno-sign-compare']