Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Task scheduler: Don't calloc in performance-critical areas

Browse Source 
Majority of the fields are being overwritten anyway, so calloc it
kinda waste of CPU ticks.
This commit is contained in:
Sergey Sharybin
2016-05-09 14:54:24 +02:00
parent 86a57b04bf
commit 9ac35be63a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/blenlib/intern/task.c
View File

@@ -344,7 +344,7 @@ static void task_scheduler_clear(TaskScheduler *scheduler, TaskPool *pool)
static TaskPool *task_pool_create_ex(TaskScheduler *scheduler, void *userdata, const bool is_background) static TaskPool *task_pool_create_ex(TaskScheduler *scheduler, void *userdata, const bool is_background)
{ {
TaskPool *pool = MEM_callocN(sizeof(TaskPool), "TaskPool"); TaskPool *pool = MEM_mallocN(sizeof(TaskPool), "TaskPool");
#ifndef NDEBUG #ifndef NDEBUG
/* Assert we do not try to create a background pool from some parent task - those only work OK from main thread. */ /* Assert we do not try to create a background pool from some parent task - those only work OK from main thread. */
@@ -360,6 +360,7 @@ static TaskPool *task_pool_create_ex(TaskScheduler *scheduler, void *userdata, c
pool->scheduler = scheduler; pool->scheduler = scheduler;
pool->num = 0; pool->num = 0;
pool->done = 0;
pool->num_threads = 0; pool->num_threads = 0;
pool->currently_running_tasks = 0; pool->currently_running_tasks = 0;
pool->do_cancel = false; pool->do_cancel = false;
@@ -425,7 +426,7 @@ void BLI_task_pool_push_ex(
TaskPool *pool, TaskRunFunction run, void *taskdata, TaskPool *pool, TaskRunFunction run, void *taskdata,
bool free_taskdata, TaskFreeFunction freedata, TaskPriority priority) bool free_taskdata, TaskFreeFunction freedata, TaskPriority priority)
{ {
Task *task = MEM_callocN(sizeof(Task), "Task"); Task *task = MEM_mallocN(sizeof(Task), "Task");
task->run = run; task->run = run;
task->taskdata = taskdata; task->taskdata = taskdata;