Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Sculpt: disable undo from any UI elements in sculpt mode

Browse Source 
Causes undo push in sculpt mode, see: T71434
This commit is contained in:
Campbell Barton
2019-11-14 19:48:29 +11:00
parent bcff803712
commit 9fff74f144
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/editors/interface/interface_handlers.c
View File

@@ -764,6 +764,7 @@ static void ui_apply_but_undo(uiBut *but)
if (but->flag & UI_BUT_UNDO) { if (but->flag & UI_BUT_UNDO) {
const char *str = NULL; const char *str = NULL;
bool skip_undo = false;
/* define which string to use for undo */ /* define which string to use for undo */
if (but->type == UI_BTYPE_MENU) { if (but->type == UI_BTYPE_MENU) {
@@ -792,11 +793,23 @@ static void ui_apply_but_undo(uiBut *but)
else { else {
ID *id = but->rnapoin.owner_id; ID *id = but->rnapoin.owner_id;
if (!ED_undo_is_legacy_compatible_for_property(but->block->evil_C, id)) { if (!ED_undo_is_legacy_compatible_for_property(but->block->evil_C, id)) {
str = ""; skip_undo = true;
} }
} }
} }
if (skip_undo == false) {
/* XXX: disable all undo pushes from UI changes from sculpt mode as they cause memfile undo
* steps to be written which cause lag: T71434. */
if (BKE_paintmode_get_active_from_context(but->block->evil_C) == PAINT_MODE_SCULPT) {
skip_undo = true;
}
}
if (skip_undo) {
str = "";
}
/* delayed, after all other funcs run, popups are closed, etc */ /* delayed, after all other funcs run, popups are closed, etc */
after = ui_afterfunc_new(); after = ui_afterfunc_new();
BLI_strncpy(after->undostr, str, sizeof(after->undostr)); BLI_strncpy(after->undostr, str, sizeof(after->undostr));