Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Tests: Avoid access globals from abstract base class

Browse Source 
Delegate functionality to subclasses, assert when subclasses didn't do
job the are supposed to do.

Thanks Sybren for pointing to a proper solution.
This commit is contained in:
Sergey Sharybin
2018-03-02 11:16:59 +01:00
parent f2a2d5492b
commit b5b34bc2c0
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/python/modules/test_utils.py
View File

@@ -58,11 +58,10 @@ def with_tempdir(wrapped):
class AbstractBlenderRunnerTest(unittest.TestCase): class AbstractBlenderRunnerTest(unittest.TestCase):
"""Base class for all test suites which needs to run Blender""" """Base class for all test suites which needs to run Blender"""
@classmethod # Set in a subclass
def setUpClass(cls): blender: pathlib.Path = None
global args testdir: pathlib.Path = None
cls.blender = args.blender
cls.testdir = pathlib.Path(args.testdir)
def run_blender(self, filepath: str, python_script: str, timeout: int=300) -> str: def run_blender(self, filepath: str, python_script: str, timeout: int=300) -> str:
"""Runs Blender by opening a blendfile and executing a script. """Runs Blender by opening a blendfile and executing a script.
@@ -73,6 +72,9 @@ class AbstractBlenderRunnerTest(unittest.TestCase):
:param timeout: in seconds :param timeout: in seconds
""" """
assert self.blender, "Path to Blender binary is to be set in setUpClass()"
assert self.testdir, "Path to tests binary is to be set in setUpClass()"
blendfile = self.testdir / filepath blendfile = self.testdir / filepath
command = ( command = (