Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Clamp dot-product to avoid precision error

Browse Source 
Would only happen in degenerate cases.
This commit is contained in:
Campbell Barton
2016-05-08 00:02:34 +10:00
parent 1c46ecd86b
commit e5b4e6b0a3
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extern/curve_fit_nd/intern/curve_fit_cubic.c vendored
View File

@@ -419,7 +419,8 @@ static double points_calc_circumference_factor(
const double dot = dot_vnvn(tan_l, tan_r, dims); const double dot = dot_vnvn(tan_l, tan_r, dims);
const double len_tangent = dot < 0.0 ? len_vnvn(tan_l, tan_r, dims) : len_negated_vnvn(tan_l, tan_r, dims); const double len_tangent = dot < 0.0 ? len_vnvn(tan_l, tan_r, dims) : len_negated_vnvn(tan_l, tan_r, dims);
if (len_tangent > DBL_EPSILON) { if (len_tangent > DBL_EPSILON) {
double angle = acos(-fabs(dot)); /* only clamp to avoid precision error */
double angle = acos(max(-fabs(dot), -1.0));
/* Angle may be less than the length when the tangents define >180 degrees of the circle, /* Angle may be less than the length when the tangents define >180 degrees of the circle,
* (tangents that point away from each other). * (tangents that point away from each other).
* We could try support this but will likely cause extreme >1 scales which could cause other issues. */ * We could try support this but will likely cause extreme >1 scales which could cause other issues. */