Style cleanup: C & pep8

This commit is contained in:
Campbell Barton
2014-04-15 13:11:48 +10:00
parent 3cf39fc72a
commit ea610e655c
11 changed files with 29 additions and 25 deletions

View File

@@ -113,7 +113,7 @@ def main():
fsrc.close() fsrc.close()
del fsrc del fsrc
# namespace hack # namespace hack
vars = ( vars = (
"BMO_OP_SLOT_ELEMENT_BUF", "BMO_OP_SLOT_ELEMENT_BUF",
"BMO_OP_SLOT_BOOL", "BMO_OP_SLOT_BOOL",

View File

@@ -47,12 +47,12 @@ class CyclesButtonsPanel():
def poll(cls, context): def poll(cls, context):
rd = context.scene.render rd = context.scene.render
return rd.engine in cls.COMPAT_ENGINES return rd.engine in cls.COMPAT_ENGINES
def use_cpu(context): def use_cpu(context):
cscene = context.scene.cycles cscene = context.scene.cycles
device_type = context.user_preferences.system.compute_device_type device_type = context.user_preferences.system.compute_device_type
return (device_type == 'NONE' or cscene.device == 'CPU') return (device_type == 'NONE' or cscene.device == 'CPU')
@@ -1126,7 +1126,7 @@ class CyclesTexture_PT_colors(CyclesButtonsPanel, Panel):
def poll(cls, context): def poll(cls, context):
# node = context.texture_node # node = context.texture_node
return False return False
#return node and CyclesButtonsPanel.poll(context) # return node and CyclesButtonsPanel.poll(context)
def draw(self, context): def draw(self, context):
layout = self.layout layout = self.layout

View File

@@ -204,8 +204,10 @@ class BPyOpsSubModOp(object):
import bpy import bpy
idname = self.idname() idname = self.idname()
as_string = op_as_string(idname) as_string = op_as_string(idname)
# XXX You never quite know what you get from bpy.types, with operators... Operator and OperatorProperties # XXX You never quite know what you get from bpy.types,
# are shadowing each other, and not in the same way for native ops and py ones! See T39158. # with operators... Operator and OperatorProperties
# are shadowing each other, and not in the same way for
# native ops and py ones! See T39158.
# op_class = getattr(bpy.types, idname) # op_class = getattr(bpy.types, idname)
op_class = op_get_rna(idname) op_class = op_get_rna(idname)
descr = op_class.bl_rna.description descr = op_class.bl_rna.description

View File

@@ -49,13 +49,15 @@ class MyCustomSocket(NodeSocket):
def draw_color(self, context, node): def draw_color(self, context, node):
return (1.0, 0.4, 0.216, 0.5) return (1.0, 0.4, 0.216, 0.5)
# Mix-in class for all custom nodes in this tree type. # Mix-in class for all custom nodes in this tree type.
# Defines a poll function to enable instantiation. # Defines a poll function to enable instantiation.
class MyCustomTreeNode : class MyCustomTreeNode:
@classmethod @classmethod
def poll(cls, ntree): def poll(cls, ntree):
return ntree.bl_idname == 'CustomTreeType' return ntree.bl_idname == 'CustomTreeType'
# Derived from the Node base type. # Derived from the Node base type.
class MyCustomNode(Node, MyCustomTreeNode): class MyCustomNode(Node, MyCustomTreeNode):
# === Basics === # === Basics ===
@@ -123,6 +125,7 @@ class MyCustomNode(Node, MyCustomTreeNode):
import nodeitems_utils import nodeitems_utils
from nodeitems_utils import NodeCategory, NodeItem from nodeitems_utils import NodeCategory, NodeItem
# our own base class with an appropriate poll function, # our own base class with an appropriate poll function,
# so the categories only show up in our own tree type # so the categories only show up in our own tree type
class MyNodeCategory(NodeCategory): class MyNodeCategory(NodeCategory):
@@ -143,12 +146,12 @@ node_categories = [
# NB: settings values are stored as string expressions, # NB: settings values are stored as string expressions,
# for this reason they should be converted to strings using repr() # for this reason they should be converted to strings using repr()
NodeItem("CustomNodeType", label="Node A", settings={ NodeItem("CustomNodeType", label="Node A", settings={
"myStringProperty" : repr("Lorem ipsum dolor sit amet"), "myStringProperty": repr("Lorem ipsum dolor sit amet"),
"myFloatProperty" : repr(1.0), "myFloatProperty": repr(1.0),
}), }),
NodeItem("CustomNodeType", label="Node B", settings={ NodeItem("CustomNodeType", label="Node B", settings={
"myStringProperty" : repr("consectetur adipisicing elit"), "myStringProperty": repr("consectetur adipisicing elit"),
"myFloatProperty" : repr(2.0), "myFloatProperty": repr(2.0),
}), }),
]), ]),
] ]

View File

@@ -16,7 +16,6 @@ def main(context, event, ray_max=10000.0):
ray_origin = view3d_utils.region_2d_to_origin_3d(region, rv3d, coord) ray_origin = view3d_utils.region_2d_to_origin_3d(region, rv3d, coord)
ray_target = ray_origin + (view_vector * ray_max) ray_target = ray_origin + (view_vector * ray_max)
def visible_objects_and_duplis(): def visible_objects_and_duplis():
"""Loop over (object, matrix) pairs (mesh only)""" """Loop over (object, matrix) pairs (mesh only)"""

View File

@@ -42,22 +42,22 @@ class LayoutDemoPanel(bpy.types.Panel):
col.label(text="Column Two:") col.label(text="Column Two:")
col.prop(scene, "frame_start") col.prop(scene, "frame_start")
col.prop(scene, "frame_end") col.prop(scene, "frame_end")
# Big render button # Big render button
layout.label(text="Big Button:") layout.label(text="Big Button:")
row = layout.row() row = layout.row()
row.scale_y = 3.0 row.scale_y = 3.0
row.operator("render.render") row.operator("render.render")
# Different sizes in a row # Different sizes in a row
layout.label(text="Different button sizes:") layout.label(text="Different button sizes:")
row = layout.row(align=True) row = layout.row(align=True)
row.operator("render.render") row.operator("render.render")
sub = row.row() sub = row.row()
sub.scale_x = 2.0 sub.scale_x = 2.0
sub.operator("render.render") sub.operator("render.render")
row.operator("render.render") row.operator("render.render")

View File

@@ -169,7 +169,7 @@ static void paint_brush_update(bContext *C, Brush *brush, PaintMode mode,
* brush coord/pressure/etc. * brush coord/pressure/etc.
* It's more an events design issue, which doesn't split coordinate/pressure/angle * It's more an events design issue, which doesn't split coordinate/pressure/angle
* changing events. We should avoid this after events system re-design */ * changing events. We should avoid this after events system re-design */
if(!stroke->brush_init) { if (!stroke->brush_init) {
copy_v2_v2(stroke->initial_mouse, mouse); copy_v2_v2(stroke->initial_mouse, mouse);
copy_v2_v2(ups->last_rake, mouse); copy_v2_v2(ups->last_rake, mouse);
copy_v2_v2(ups->tex_mouse, mouse); copy_v2_v2(ups->tex_mouse, mouse);

View File

@@ -2414,8 +2414,8 @@ static void draw_dm_loop_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
if (lnors) { if (lnors) {
drawDMNormal_userData data; drawDMNormal_userData data;
MLoop *mloops = dm->getLoopArray(dm); const MLoop *mloops = dm->getLoopArray(dm);
MVert *mverts = dm->getVertArray(dm); const MVert *mverts = dm->getVertArray(dm);
int i, totloops = dm->getNumLoops(dm); int i, totloops = dm->getNumLoops(dm);
data.bm = em->bm; data.bm = em->bm;
@@ -2426,7 +2426,7 @@ static void draw_dm_loop_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
glBegin(GL_LINES); glBegin(GL_LINES);
for (i = 0; i < totloops; i++, mloops++, lnors++) { for (i = 0; i < totloops; i++, mloops++, lnors++) {
float no[3]; float no[3];
float *co = mverts[mloops->v].co; const float *co = mverts[mloops->v].co;
if (!data.uniform_scale) { if (!data.uniform_scale) {
mul_v3_m3v3(no, data.tmat, (float *)lnors); mul_v3_m3v3(no, data.tmat, (float *)lnors);
@@ -2434,7 +2434,7 @@ static void draw_dm_loop_normals(BMEditMesh *em, Scene *scene, Object *ob, Deriv
mul_m3_v3(data.imat, no); mul_m3_v3(data.imat, no);
} }
else { else {
copy_v3_v3(no,(float *)lnors); copy_v3_v3(no, (float *)lnors);
} }
mul_v3_fl(no, data.normalsize); mul_v3_fl(no, data.normalsize);
add_v3_v3(no, co); add_v3_v3(no, co);

View File

@@ -424,7 +424,7 @@ static void rna_MeshTessFace_split_normals_get(PointerRNA *ptr, float *values)
while (i--) zero_v3(&values[i * 3]); while (i--) zero_v3(&values[i * 3]);
} }
else { else {
while (i--) normal_short_to_float_v3(&values[i * 3], (const short*)(*vec)[i]); while (i--) normal_short_to_float_v3(&values[i * 3], (const short *)(*vec)[i]);
} }
} }

View File

@@ -105,7 +105,7 @@ def blend_list(mainpath):
def is_blend(filename): def is_blend(filename):
ext = splitext(filename)[1] ext = splitext(filename)[1]
return (ext in {".blend",}) return (ext in {".blend", })
return list(sorted(file_list(mainpath, is_blend))) return list(sorted(file_list(mainpath, is_blend)))

View File

@@ -54,7 +54,7 @@ def is_pep8(path):
print("\nfile contains BOM, remove first 3 bytes: %r\n" % path) print("\nfile contains BOM, remove first 3 bytes: %r\n" % path)
# templates don't have a header but should be pep8 # templates don't have a header but should be pep8
for d in ("presets", "templates", "examples"): for d in ("presets", "templates_py", "examples"):
if ("%s%s%s" % (os.sep, d, os.sep)) in path: if ("%s%s%s" % (os.sep, d, os.sep)) in path:
return 1 return 1