Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Remove unnecessary constructor argument

Browse Source 
All attributes should be writeable, it is now only needed for the
legacy `normal` attribute on meshes.
This commit is contained in:
Hans Goudey
2021-10-18 12:35:27 -05:00
parent 9f895fbb97
commit ec8a9a0d65
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/blenkernel/intern/geometry_component_curve.cc
View File

@@ -980,16 +980,15 @@ template<typename T> class BuiltinPointAttributeProvider : public BuiltinAttribu
public: public:
BuiltinPointAttributeProvider(std::string attribute_name, BuiltinPointAttributeProvider(std::string attribute_name,
const WritableEnum writable,
const GetSpan get_span, const GetSpan get_span,
const GetMutableSpan get_mutable_span, const GetMutableSpan get_mutable_span,
const UpdateOnWrite update_on_write) const UpdateOnWrite update_on_write)
: BuiltinAttributeProvider(std::move(attribute_name), : BuiltinAttributeProvider(std::move(attribute_name),
ATTR_DOMAIN_POINT, ATTR_DOMAIN_POINT,
bke::cpp_type_to_custom_data_type(CPPType::get<T>()), bke::cpp_type_to_custom_data_type(CPPType::get<T>()),
BuiltinAttributeProvider::NonCreatable, CreatableEnum::NonCreatable,
writable, WritableEnum::Writable,
BuiltinAttributeProvider::NonDeletable), DeletableEnum::NonDeletable),
get_span_(get_span), get_span_(get_span),
get_mutable_span_(get_mutable_span), get_mutable_span_(get_mutable_span),
update_on_write_(update_on_write) update_on_write_(update_on_write)
@@ -1091,7 +1090,6 @@ class PositionAttributeProvider final : public BuiltinPointAttributeProvider<flo
PositionAttributeProvider() PositionAttributeProvider()
: BuiltinPointAttributeProvider( : BuiltinPointAttributeProvider(
"position", "position",
BuiltinAttributeProvider::Writable,
[](const Spline &spline) { return spline.positions(); }, [](const Spline &spline) { return spline.positions(); },
[](Spline &spline) { return spline.positions(); }, [](Spline &spline) { return spline.positions(); },
[](Spline &spline) { spline.mark_cache_invalid(); }) [](Spline &spline) { spline.mark_cache_invalid(); })
@@ -1491,14 +1489,12 @@ static ComponentAttributeProviders create_attribute_providers_for_curve()
static BuiltinPointAttributeProvider<float> radius( static BuiltinPointAttributeProvider<float> radius(
"radius", "radius",
BuiltinAttributeProvider::Writable,
[](const Spline &spline) { return spline.radii(); }, [](const Spline &spline) { return spline.radii(); },
[](Spline &spline) { return spline.radii(); }, [](Spline &spline) { return spline.radii(); },
nullptr); nullptr);
static BuiltinPointAttributeProvider<float> tilt( static BuiltinPointAttributeProvider<float> tilt(
"tilt", "tilt",
BuiltinAttributeProvider::Writable,
[](const Spline &spline) { return spline.tilts(); }, [](const Spline &spline) { return spline.tilts(); },
[](Spline &spline) { return spline.tilts(); }, [](Spline &spline) { return spline.tilts(); },
[](Spline &spline) { spline.mark_cache_invalid(); }); [](Spline &spline) { spline.mark_cache_invalid(); });