Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix T92180: Curve subdivide incorrect result for poly splines

Browse Source 
The node shifted all new points forward in the spline, so the first
point would appear to be removed.
This commit is contained in:
Hans Goudey
2021-10-13 14:28:05 -05:00
parent 10abaf3ddf
commit 1ae79b704a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc
View File

@@ -63,9 +63,9 @@ static void subdivide_attribute(Span<T> src,
for (const int i : range) {
const int cuts = offsets[i + 1] - offsets[i];
dst[offsets[i]] = src[i];
const float factor_delta = 1.0f / (cuts + 1.0f);
const float factor_delta = cuts == 0 ? 1.0f : 1.0f / cuts;
for (const int cut : IndexRange(cuts)) {
const float factor = (cut + 1) * factor_delta;
const float factor = cut * factor_delta;
dst[offsets[i] + cut] = attribute_math::mix2(factor, src[i], src[i + 1]);
}
}
@@ -75,9 +75,9 @@ static void subdivide_attribute(Span<T> src,
const int i = src_size - 1;
const int cuts = offsets[i + 1] - offsets[i];
dst[offsets[i]] = src.last();
const float factor_delta = 1.0f / (cuts + 1.0f);
const float factor_delta = cuts == 0 ? 1.0f : 1.0f / cuts;
for (const int cut : IndexRange(cuts)) {
const float factor = (cut + 1) * factor_delta;
const float factor = cut * factor_delta;
dst[offsets[i] + cut] = attribute_math::mix2(factor, src.last(), src.first());
}
}