fix comparison of identicals
Some of these check that dimensions match before running code that assumes they do match. For imb_stereo3d_write_anaglyph I *assume* this change reflects the intended behavior. Before it was always grabbing alpha from buffer 0. Found with PVS-Studio T48917
This commit is contained in:
@@ -109,7 +109,7 @@ void MeanAndVarianceAlongRows(const Mat &A,
|
||||
}
|
||||
|
||||
void HorizontalStack(const Mat &left, const Mat &right, Mat *stacked) {
|
||||
assert(left.rows() == left.rows());
|
||||
assert(left.rows() == right.rows());
|
||||
int n = left.rows();
|
||||
int m1 = left.cols();
|
||||
int m2 = right.cols();
|
||||
|
@@ -206,7 +206,7 @@ void imb_filterx(struct ImBuf *ibuf)
|
||||
static void imb_filterN(ImBuf *out, ImBuf *in)
|
||||
{
|
||||
BLI_assert(out->channels == in->channels);
|
||||
BLI_assert(out->x == in->x && out->y == out->y);
|
||||
BLI_assert(out->x == in->x && out->y == in->y);
|
||||
|
||||
const int channels = in->channels;
|
||||
const int rowlen = in->x;
|
||||
|
@@ -117,7 +117,7 @@ static void imb_stereo3d_write_anaglyph(Stereo3DData *s3d, enum eStereo3dAnaglyp
|
||||
to[0] = from[r][0];
|
||||
to[1] = from[g][1];
|
||||
to[2] = from[b][2];
|
||||
to[3] = MAX2(from[0][3], from[0][3]);
|
||||
to[3] = MAX2(from[0][3], from[1][3]);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -154,7 +154,7 @@ static void imb_stereo3d_write_anaglyph(Stereo3DData *s3d, enum eStereo3dAnaglyp
|
||||
to[0] = from[r][0];
|
||||
to[1] = from[g][1];
|
||||
to[2] = from[b][2];
|
||||
to[3] = MAX2(from[0][3], from[0][3]);
|
||||
to[3] = MAX2(from[0][3], from[1][3]);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user