Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Alembic: transformed chain-of-ifs into switch statement

Browse Source 
By having a switch statement that lists all the values of the enum, it is
clear which cases we're not handling, and it also allows for warnings in
the future when the enum expands.

No functional changes.
This commit is contained in:
Sybren A. Stüvel
2019-07-04 11:53:17 +02:00
parent d65a4b5990
commit 3568d56bcc
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
source/blender/alembic/intern/abc_mesh.cc
View File

@@ -919,11 +919,19 @@ ABC_INLINE void read_normals_params(AbcMeshData &abc_data,
IN3fGeomParam::Sample normsamp = normals.getExpandedValue(selector);
if (normals.getScope() == kFacevaryingScope) {
abc_data.face_normals = normsamp.getVals();
}
else if ((normals.getScope() == kVertexScope) || (normals.getScope() == kVaryingScope)) {
abc_data.vertex_normals = N3fArraySamplePtr();
Alembic::AbcGeom::GeometryScope scope = normals.getScope();
switch (scope) {
case Alembic::AbcGeom::kFacevaryingScope:
abc_data.face_normals = normsamp.getVals();
break;
case Alembic::AbcGeom::kVertexScope:
case Alembic::AbcGeom::kVaryingScope:
abc_data.vertex_normals = N3fArraySamplePtr();
break;
case Alembic::AbcGeom::kConstantScope:
case Alembic::AbcGeom::kUniformScope:
case Alembic::AbcGeom::kUnknownScope:
break;
}
}