Fix T80774: (correction) keep MEM_init_memleak_detection call early

This commit is contained in:
Campbell Barton
2020-09-15 13:23:06 +10:00
parent 2120acb73e
commit 62f2925e43
3 changed files with 22 additions and 3 deletions

View File

@@ -215,6 +215,12 @@ extern const char *(*MEM_name_ptr)(void *vmemh);
* about memory leaks will be printed on exit. */
void MEM_init_memleak_detection(void);
/**
* Use this if we want to call #exit during argument parsing for example,
* without having to free all data.
*/
void MEM_use_memleak_detection(bool enabled);
/** When this has been called and memory leaks have been detected, the process will have an exit
* code that indicates failure. This can be used for when checking for memory leaks with automated
* tests. */

View File

@@ -32,11 +32,15 @@ char free_after_leak_detection_message[] =
namespace {
bool fail_on_memleak = false;
bool ignore_memleak = false;
class MemLeakPrinter {
public:
~MemLeakPrinter()
{
if (ignore_memleak) {
return;
}
leak_detector_has_run = true;
const uint leaked_blocks = MEM_get_memory_blocks_in_use();
if (leaked_blocks == 0) {
@@ -74,6 +78,11 @@ void MEM_init_memleak_detection(void)
static MemLeakPrinter printer;
}
void MEM_use_memleak_detection(bool enabled)
{
ignore_memleak = !enabled;
}
void MEM_enable_fail_on_memleak(void)
{
fail_on_memleak = true;

View File

@@ -297,6 +297,7 @@ int main(int argc,
break;
}
}
MEM_init_memleak_detection();
}
#ifdef BUILD_DATE
@@ -399,6 +400,10 @@ int main(int argc,
main_args_setup(C, ba);
/* Begin argument parsing, ignore leaks so arguments that call #exit
* (such as '--version' & '--help') don't report leaks. */
MEM_use_memleak_detection(false);
BLI_argsParse(ba, 1, NULL, NULL);
main_signal_setup();
@@ -499,9 +504,8 @@ int main(int argc,
callback_main_atexit(&app_init_data);
BKE_blender_atexit_unregister(callback_main_atexit, &app_init_data);
/* Initialize memory leak detection after parsing command line arguments
* so arguments that call #exit (such as '--version' & '--help') don't report leaks. */
MEM_init_memleak_detection();
/* End argument parsing, allow memory leaks to be printed. */
MEM_use_memleak_detection(true);
/* Paranoid, avoid accidental re-use. */
#ifndef WITH_PYTHON_MODULE