Cr8-xyz/blender
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert "Cycles Tests: Add test for correct 16 byte alignment of KernelData structs"

Browse Source 
Using unit tests is a wrong way to control static behavior of the
application. They should only be used for checking dynamic behavior,
all the rest is easily controllable at compile time.

Doing tests at ocmpile time are actually more robust approach since
we don't have strict policy of runnign unit tests before accepting
any change.

Proper alignment control is coming shortly.

This reverts commit 7c3a06c349.
This commit is contained in:
Sergey Sharybin
2016-08-11 10:08:23 +02:00
parent 7c3a06c349
commit a501668cc5
2 changed files with 0 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
intern/cycles/test/CMakeLists.txt
View File

@@ -69,4 +69,3 @@ CYCLES_TEST(util_aligned_malloc "cycles_util")
CYCLES_TEST(util_path "cycles_util;${BOOST_LIBRARIES};${OPENIMAGEIO_LIBRARIES}")
CYCLES_TEST(util_string "cycles_util;${BOOST_LIBRARIES}")
CYCLES_TEST(util_task "cycles_util;${BOOST_LIBRARIES}")
CYCLES_TEST(kernel_struct_align "")

60
intern/cycles/test/kernel_struct_align_test.cpp
View File

@@ -1,60 +0,0 @@
/*
* Copyright 2011-2016 Blender Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "testing/testing.h"
#include "kernel/kernel_types.h"
CCL_NAMESPACE_BEGIN
#define TEST_IS_ALIGNED(name) ((sizeof(name) % 16) == 0)
TEST(kernel_struct_align, KernelCamera)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelCamera));
}
TEST(kernel_struct_align, KernelFilm)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelFilm));
}
TEST(kernel_struct_align, KernelBackground)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelBackground));
}
TEST(kernel_struct_align, KernelIntegrator)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelIntegrator));
}
TEST(kernel_struct_align, KernelBVH)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelBVH));
}
TEST(kernel_struct_align, KernelCurves)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelCurves));
}
TEST(kernel_struct_align, KernelTables)
{
EXPECT_TRUE(TEST_IS_ALIGNED(KernelTables));
}
CCL_NAMESPACE_END